lei added inline comments.
================ Comment at: clang/include/clang/Basic/BuiltinsPPC.def:48 BUILTIN(__builtin_ppc_icbt, "vv*", "") +BUILTIN(__builtin_ppc_alignx, "viCvC*", "nc") +BUILTIN(__builtin_ppc_rdlam, "UWiUWiUWiCUWi", "nc") ---------------- I think you need sema checking for parm 1. ``` alignment Must be a constant integer with a value greater than zero and of a power of two. ``` ================ Comment at: clang/include/clang/Basic/BuiltinsPPC.def:49 +BUILTIN(__builtin_ppc_alignx, "viCvC*", "nc") +BUILTIN(__builtin_ppc_rdlam, "UWiUWiUWiCUWi", "nc") ---------------- sema checking? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104386/new/ https://reviews.llvm.org/D104386 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
