lei added inline comments.
================ Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.td:3087 // RM should be set. +let hasSideEffects = 1 in { def MTFSB0 : XForm_43<63, 70, (outs), (ins u5imm:$FM), ---------------- nemanjai wrote: > nemanjai wrote: > > I think we should conservatively set RM as an implicit def here. @ZhangKang > > you modified this code most recently, please provide your opinion here. > This was not addressed. Will this be added in a follow-up patch? Yes, sorry I will address this in a subsequent patch since adding RM will cause unrelated LIT failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105930/new/ https://reviews.llvm.org/D105930 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits