eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:1174 + CompileKernel, Recover, + /*IsOptNull=*/CodeGenOpts.OptimizationLevel == 0)); } ---------------- DisableOptimization= ================ Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:407 bool Recover; + bool DisableOptimization; }; ---------------- fmayer wrote: > fmayer wrote: > > eugenis wrote: > > > No need to pass this down, just look at OptimizeNone function attribute. > > Interesting, the Aarch64StackTagging code does pass this down, do you know > > why? > Also we really should be using this at least in the getAnalysisUsage, which > Vitaly's change made unconditional. Correct? Ah right. Legacy pass needs to declare its analysis dependencies in advance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits