dblaikie added a comment. In D101566#2891699 <https://reviews.llvm.org/D101566#2891699>, @aaronpuchert wrote:
> @dblaikie, does https://bugs.llvm.org/show_bug.cgi?id=18733#c17 or the > following comment change anything about your position? No, not really. This patch is still conflating two things - effectively removing an existing warning (which I agree with) and adding a new one (which I think is questionable at best - but in any case should be evaluated on its own merits (& if we did that, we might consider generalizing it beyond only templates with vtables, for instance (why are they more deserving of explicit instantiations than other templates?)), not in relation to the existing broken warning). The two warnings (the buggy one being removed, and the new one being proposed) are exact opposites of each other, with no overlap - it doesn't seem suitable to conflate the two in one review, and potentially not to reuse the same warning flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101566/new/ https://reviews.llvm.org/D101566 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
