lei added inline comments.
================ Comment at: clang/include/clang/Basic/BuiltinsPPC.def:116 BUILTIN(__builtin_ppc_fres, "ff", "") +BUILTIN(__builtin_ppc_stbcx, "icD*i", "") ---------------- maybe move this up to where `__builtin_ppc_stdcx` is defined. To match what you did in `PPC.cpp` ================ Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:31 + return __builtin_ppc_stbcx(c_addr, c); +} ---------------- Why not just add this tc to `clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c`? The other related store functions are tested there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106484/new/ https://reviews.llvm.org/D106484 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
