jacquesguan added inline comments.
================
Comment at: clang/include/clang/Basic/riscv_vector.td:693
+ let Name = op # eew64 # "_v", IRName = op, IRNameMask = op # "_mask",
+ RequiredExtensions = ["Xlen64"] in {
+ def: RVVBuiltin<"v", "vPCe" # eew64_type # "Uv", type>;
----------------
jrtc27 wrote:
> Xlen64 is not an extension. Nor is RV64I, even, it is a base ISA, but that
> would at least be somewhat defensible. In fact, Xlen64 would be parsed as a
> valid non-standard extension called "Xlen" with major version 64 and minor
> version 0, just like any other Xfoo.
So change Xlen64 to RV64 or create a new field of RVVBuiltin to describle it?
Which one do you think is better?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106518/new/
https://reviews.llvm.org/D106518
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
