kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/CompileCommands.cpp:225 + auto It = llvm::find(Cmd, "--"); + for (std::string &Arg : ToAppend) + Cmd.insert(It++, std::move(Arg)); ---------------- sammccall wrote: > oops, might have left this comment on the wrong patch > > use range insert to save shuffling the tail over and over and > std::make_move_iterator() to avoid copies? yeah the main reason this is a loop is because I didn't know about `make_move_iterator`, switching to a range insert instead, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106562/new/ https://reviews.llvm.org/D106562 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
