junparser added inline comments.
================ Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2102 + Src = Builder.CreateBitCast(Src, SrcTy); + } if (ScalableSrc->getElementType() == FixedDst->getElementType()) { ---------------- bsmith wrote: > junparser wrote: > > I think this may also works for casting between vectors with different > > element types. > A similar argument applies here as the other related ticket, in principal we > could, however it's not clear that there is a good use case for writing code > that would make use of this. So for now it's probably best to just deal with > predicates which are definitely a problem and other cases as they arise. Although i believe this generates better code than using memory load/store. Thanks for explaining this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106860/new/ https://reviews.llvm.org/D106860 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits