Hmmmm yeah, just because your compiler has both ppc and x86 targets doesn’t mean your system assembler is willing to target x86. I think it can keep the -integrated-as steps that verify the warning does what’s expected, and abandon actually running the external assembler. The -target options for the integrated assembler can also probably be removed again (I added that in my first try to fix the bots). Thanks, hope the next step works… --paulr
From: Hubert Tong <hubert.reinterpretc...@gmail.com> Sent: Friday, July 30, 2021 1:26 PM To: Robinson, Paul <paul.robin...@sony.com> Cc: Amy Huang <llvmlist...@llvm.org>; cfe-commits <cfe-commits@lists.llvm.org> Subject: Re: [clang] 9ca905b - XFAIL a test on ppc64 On Fri, Jul 30, 2021 at 12:59 PM <paul.robin...@sony.com<mailto:paul.robin...@sony.com>> wrote: Do you have a suggestion for how to fix it? This isn’t actually my test, I tripped over it and it seemed like it would be easy to get it to work. ☹ I think removing all of the `-target` options might help. Alternatively, I don't see why the test should actually call out to the assembler (could just check the driver would invoke it with the options of interest). If the test is also meant to check that an error from the native assembler produces an error return code from the driver, then that could be tested using an ersatz assembler picked up using `-B` (but I would hope that there's a different test to cover that already). Thanks, --paulr From: Hubert Tong <hubert.reinterpretc...@gmail.com<mailto:hubert.reinterpretc...@gmail.com>> Sent: Friday, July 30, 2021 12:43 PM To: Robinson, Paul <paul.robin...@sony.com<mailto:paul.robin...@sony.com>>; Paul Robinson <llvmlist...@llvm.org<mailto:llvmlist...@llvm.org>> Cc: cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> Subject: Re: [clang] 9ca905b - XFAIL a test on ppc64 On Fri, Jul 30, 2021 at 12:05 PM Paul Robinson via cfe-commits <cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>> wrote: Author: Paul Robinson Date: 2021-07-30T09:05:14-07:00 New Revision: 9ca905b52d53c46aceb4d28e44dfbf4a815d0c68 URL: https://github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68<https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68__;!!JmoZiZGBv3RvKRSx!v4BWRPD6Co0A_0iVezXCtxoroTbBRK8XfnUbtx43IGKDafGio87LV_HvS_y3xwuhfg$> DIFF: https://github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68.diff<https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44dfbf4a815d0c68.diff__;!!JmoZiZGBv3RvKRSx!v4BWRPD6Co0A_0iVezXCtxoroTbBRK8XfnUbtx43IGKDafGio87LV_HvS_xqgmn2aA$> LOG: XFAIL a test on ppc64 Buildbot failure: https://lab.llvm.org/buildbot/#/builders/105/builds/13141<https://urldefense.com/v3/__https:/lab.llvm.org/buildbot/*/builders/105/builds/13141__;Iw!!JmoZiZGBv3RvKRSx!v4BWRPD6Co0A_0iVezXCtxoroTbBRK8XfnUbtx43IGKDafGio87LV_HvS_xATeKedQ$> which provides no details about why it failed, Which would be because the test is set up to display warnings but won't display errors. /usr/bin/as: unrecognized option '--32' I also tried `x86_64-pc-linux-gnu`: /usr/bin/as: unrecognized option '--64' It probably makes sense that these options aren't supported if the system is 64-bit only. but the only failure reports are for ppc64 bots. Added: Modified: clang/test/Driver/as-no-warnings.c Removed: ################################################################################ diff --git a/clang/test/Driver/as-no-warnings.c b/clang/test/Driver/as-no-warnings.c index 9c2b3f096872..77971389ee65 100644 --- a/clang/test/Driver/as-no-warnings.c +++ b/clang/test/Driver/as-no-warnings.c @@ -14,6 +14,7 @@ // REQUIRES: clang-driver // REQUIRES: x86-registered-target // REQUIRES: system-linux +// XFAIL: ppc64 // CHECK: "-cc1" {{.*}} "-massembler-no-warn" // CHECK-NOIAS: "--no-warn" _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits__;!!JmoZiZGBv3RvKRSx!v4BWRPD6Co0A_0iVezXCtxoroTbBRK8XfnUbtx43IGKDafGio87LV_HvS_wLZC7qfQ$>
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
