ASDenysPetrov added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1352-1356 + // key 'j' + if (event.keyCode == 74) { navigateTo(/*up=*/false); - } else if (event.key == "k") { + // key 'k' + } else if (event.keyCode == 75) { ---------------- NoQ wrote: > This probably also solves keyboard layout problems, nice! Exactly=) ================ Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1373 + var array = []; + for (var i = lower; i <= upper; ++i) { + array.push(i); ---------------- NoQ wrote: > Shouldn't it be `i < upper`? `[lower, upper).` Sure! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107366/new/ https://reviews.llvm.org/D107366 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits