erichkeane added a comment.
Just some thoughts! See what you like/don't like here, i'm not attached to my
suggestions.
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:86
+def err_drv_mix_cuda_hip : Error<
+ "mixed CUDA and HIP compilation is not supported">;
+def err_drv_bad_target_id : Error<
----------------
I wonder if this should be something more like "invalid argument '<caused
HIP>' not allowed in 'CUDA'".
Would be more consistent with the options mixed with C/C++ mode/etc.
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:88
+def err_drv_bad_target_id : Error<
+ "invalid target ID: %0 (a target ID is a processor name followed by an "
+ "optional list of predefined features post-fixed by a plus or minus sign "
----------------
invalid target ID %0; format is processor name followed by an optional colon
delimited list of features followed by enable/disable sign, .e.g.
'gfx908:sramecc+;xnack-'
?? I think we should be leaning on the example more to explain the format.
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:92
+def err_drv_bad_offload_arch_combo : Error<
+ "invalid offload arch combinations: %0 and %1 (for a specific processor, a "
+ "feature should either exist in all offload archs, or not exist in any "
----------------
This is an improvement, but this one is... rough. Not sure enough of what it
is saying unfortunately to suggest a better wording.
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:276
def err_drv_omp_host_ir_file_not_found : Error<
- "The provided host compiler IR file '%0' is required to generate code for
OpenMP target regions but cannot be found.">;
+ "provided host compiler IR file '%0' is required to generate code for OpenMP
"
+ "target regions but cannot be found">;
----------------
provided host compiler IR file '%0' not found; required to generate code
for OpenMP target regions
??
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:319
def warn_drv_dwarf_version_limited_by_target : Warning<
- "debug information option '%0' is not supported. It needs DWARF-%2 but
target '%1' only provides DWARF-%3.">,
+ "debug information option '%0' is not supported; it needs DWARF-%2 but "
+ "target '%1' only provides DWARF-%3">,
----------------
it 'requires' perhaps?
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:524
def warn_drv_moutline_unsupported_opt : Warning<
- "The '%0' architecture does not support -moutline; flag ignored">,
+ "the '%0' architecture does not support '-moutline'; flag ignored">,
InGroup<OptionIgnored>;
----------------
consider just removing 'the' from this and the next one.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107402/new/
https://reviews.llvm.org/D107402
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
