MaskRay added a comment. In D107684#2936034 <https://reviews.llvm.org/D107684#2936034>, @mhjacobson wrote:
> In D107684#2936033 <https://reviews.llvm.org/D107684#2936033>, @MaskRay wrote: > >> `--sysroot %S/Inputs/basic_avr_tree/usr/lib` seems incorrect. >> >> sysroot is usually a directory which contains `usr/lib` and `lib/`. >> `somewhere/usr/lib` is not usually used as a sysroot. > > Yeah, I agree it's weird. This is basically a shortcut to avoid creating a > duplicate sysroot in `Inputs`. Would you prefer I create the duplicate tree? A duplicate tree is better. Otherwise you can use `unittests/Driver/ToolChainTest.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm.org/D107684 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
