melver accepted this revision. melver added inline comments. This revision is now accepted and ready to land.
================ Comment at: llvm/include/llvm/AsmParser/LLToken.h:222 kw_nosanitize_coverage, + kw_no_sanitizer_instrumentation, kw_null_pointer_is_valid, ---------------- LLVM seems to just call them nofoo i.e. here it'd be nosanitizer_instrumentation. I think Clang and LLVM are a bit inconsistent in their naming (no_foo vs nofoo) . See e.g. nosanitize_coverage which is similarly inconsistent yet consistent with other LLVM attrs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
