dexonsmith added inline comments.
================
Comment at: llvm/lib/CodeGen/MIRSampleProfile.cpp:289
+
+bool MIRProfileLoaderPass::runOnMachineFunction(MachineFunction &MF) {
+ if (!MIRSampleLoader->isValid())
----------------
JDevlieghere wrote:
> Why is this outside the `llvm` namespace?
I think it's common style in LLVM to have function definitions outside of
namespaces -- IMO, the odd thing here is that the preceding function
definitions were inside the namespace.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107878/new/
https://reviews.llvm.org/D107878
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
