tra added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6450 llvm::raw_ostream &OS) const { - OS << ".static." << getContext().getCUIDHash(); + OS << "__static__" << getContext().getCUIDHash(); } ---------------- I would expect NVPTXAssignValidGlobalNames.cpp to deal with this ptx quirk. I'm fine with the underscores, but it would be good we're not just covering up an issue somewhere else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108456/new/ https://reviews.llvm.org/D108456 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits