vitalybuka added inline comments.
================ Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:166 + ASanAccessInfo(bool IsWrite, bool CompileKernel, uint8_t AccessSizeIndex); +}; + ---------------- .cpp file is missing ================ Comment at: llvm/lib/Target/X86/X86MCInstLower.cpp:1426 + OutStreamer->emitInstruction(MCInstBuilder(X86::AND32ri8) + .addReg(X86::ECX) + .addReg(X86::ECX) ---------------- kstoimenov wrote: > vitalybuka wrote: > > what is in ECX register here? > Should be NoRegister. Done. Why NoRegister update is not reflected in tests? ================ Comment at: llvm/test/CodeGen/X86/asan-check-memaccess-or.ll:94 +; CHECK-NEXT: movq [[REG]], %rcx +; CHECK-NEXT: andl $7, %ecx +; CHECK-NEXT: addl $1, %ecx ---------------- What is ECX here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
