MaskRay added inline comments.
================ Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2194 + getOrCreateInternalVariable(KmpCriticalNameTy, Name)); + if (!GV->isDSOLocal()) + GV->setDSOLocal(true); ---------------- MaskRay wrote: > Can be variable be preemptible on ELF? (i.e. default visibility non-local > linkage) If yes, it cannot be marked dso_local in that case. > in that case => When -fpic is used. `-fpic -shared` may give a linker error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108421/new/ https://reviews.llvm.org/D108421 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
