yaron.keren marked an inline comment as done.
yaron.keren added inline comments.


================
Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24
+# Windows: llvm-lit.py, Linux: llvm-lit
+llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0]
+lit = config.llvm_external_lit if config.llvm_external_lit else 
shell_quote(llvm_lit)
----------------
tstellar wrote:
> This patch breaks stand-alone clang builds, because it assumes llvm-lit* will 
> be present in the build directory.   This line should be guarded by if not 
> config.llvm_external_lit.
Continued in https://reviews.llvm.org/D109000


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108085/new/

https://reviews.llvm.org/D108085

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to