steakhal added a comment. Herald added a subscriber: manas. In D75171#1954405 <https://reviews.llvm.org/D75171#1954405>, @Szelethus wrote:
> In D75171#1954279 <https://reviews.llvm.org/D75171#1954279>, @sylvestre.ledru > wrote: > >> @baloghadamsoftware @Szelethus it would be great to have the name of the >> checkers in the error message >> The error is "error: checker cannot be enabled with analyzer option >> 'aggressive-binary-operation-simplification' == false" >> and I had to look at this patch to understand that it is about iterator > > Huh, that is a fair point -- Adam, can you patch it in please? IMO enabling the checker should imply enabling all the //required// options as well. So, I see very little value in this error message, not to mention that we won't know which checkers to blame. It's also really bad for //git bisecting//, when e.g. someone is simply enabling the `alpha` checkers. Suddenly, sometimes in the process, you have to pass this checker option, and in some other bisect cases, you must not pass them, because those are not yet recognized. This happened a couple of times for example reducing crashes. So, I think we should reiterate this issue. What's your take on this @Szelethus? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75171/new/ https://reviews.llvm.org/D75171 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
