GMNGeoffrey added a comment. > I had fixed this in > https://github.com/llvm/llvm-project/commit/9d227543890e721b95303430ee1427ce5aa7292f > . Precommit bot on this change was green though as far as I can tell.
Harbormaster comments with a green check mark that build has completed, but if you look at the top of the revision it has the build results. For some reason that I don't understand, the actual status at the top disappears as soon as the commit has landed, which is... very unhelpful. If you click on the Harbormaster comment now, you can see that they failed. I've reopened a diff with https://reviews.llvm.org/D109181 and will reland if premerge checks pass. Sorry that my revert went past the fix. AFAIU, I was following the guidelines in https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy. I think it would be nice to comment on the review that you are already preparing a fix (but I have no idea what the standard practice is). If I had known you were then I wouldn't have reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109167/new/ https://reviews.llvm.org/D109167 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
