whisperity added a comment. Uuuh.. I get the sentiment, but this change breaks the very essence of the joke that the default generated code wants to pass on. It also does not showcase that we can emit notes, not just warnings.
How about `function %0 is insufficiently awesome, mark it as 'awesome_'!` in the warning text? (Note how the fix and the note's text diverged already.) And so we should come up with a joke for the Note tag. BTW, the test wasn't checking for the note's message at all? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109210/new/ https://reviews.llvm.org/D109210 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
