hans added inline comments.
================
Comment at: lib/Sema/SemaTemplate.cpp:7382
@@ +7381,3 @@
+ if (A->getKind() == AttributeList::AT_DLLExport) {
+ // dllexport trumps dllexport here.
+ DLLImport = false;
----------------
thakis wrote:
> trumps _dllimport_ here
>
> (test?)
Done. Adding a test to dllexport.cpp.
================
Comment at: lib/Sema/SemaTemplate.cpp:7451
@@ -7423,1 +7450,3 @@
+ HasNoEffect = false;
+ }
}
----------------
thakis wrote:
> does moving this here change behavior? if so, maybe add a test for that too.
Nope, this doesn't change anything.
http://reviews.llvm.org/D20608
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
