rmaz added inline comments.
================
Comment at: clang/lib/Serialization/ASTReader.cpp:8194
+ if (seen.insert(M).second) {
+ S.addMethodToGlobalList(&List, M);
+ }
----------------
manmanren wrote:
> Does it make sense to check for duplication inside addMethodToGlobalList, as
> the function goes through the list as well? Maybe it is slower, as we will
> need to go through the list for each method, instead of a lookup.
Yes, you are right, it is slower as we need to do a list traverse per insert
rather than per selector lookup. I also profiled keeping some global state
along with the `MethodPool` so that the set didn't have to be rebuilt each
time, but the performance difference was negligible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109632/new/
https://reviews.llvm.org/D109632
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
