MaskRay added inline comments.

================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:978
   if (NS == 0 && !(DataReferencedByCode && NeedComdat && !Renamed) &&
-      (TT.isOSBinFormatELF() ||
+      (TT.isOSBinFormatELF() || TT.isOSBinFormatXCOFF() ||
        (!DataReferencedByCode && TT.isOSBinFormatCOFF()))) {
----------------
This place is for binary formats which can properly GC metadata sections. If 
XCOFF can't, it shouldn't be added here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110422/new/

https://reviews.llvm.org/D110422

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to