bcraig added a comment. LGTM. Probably want a "LGTM" from at least one other person though.
In http://reviews.llvm.org/D20677#441085, @rmaprath wrote: > In http://reviews.llvm.org/D20677#441061, @jroelofs wrote: > > > This is the canonical reference for the Itanium ABI: > > https://mentorembedded.github.io/cxx-abi/abi.html > > > I was indeed looking at this, but couldn't find those exact function > signatures (or something that looks like it). Perhaps it's covered there as a > more general concept. I'll have a read. https://mentorembedded.github.io/cxx-abi/abi-eh.html mentions the functions, but it doesn't really say what they are for. The C++ standard mentions when an exception of std::bad_cast and std::bad_typeid are thrown. Put those two documents together, and you get my earlier statements. Granted, it's just a well informed guess, but a guess I'm pretty confident in. Leaving those functions in should be harmless, other than the size of the dead code. There are also all the private type_info classes that are dead weight if RTTI is turned off. While it may make sense to remove those functions, that's probably best left for a different code review. http://reviews.llvm.org/D20677 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
