tejohnson added a comment. In D110276#3030390 <https://reviews.llvm.org/D110276#3030390>, @tejohnson wrote:
> In D110276#3029952 <https://reviews.llvm.org/D110276#3029952>, @thakis wrote: > >> Softlinks don't work on Windows, that's why these tests use copies. >> >> clang_f_opts.c sadly started flaking almost immediately after this went in: >> http://45.33.8.238/win/46115/step_7.txt >> >> So I fear the Windows file system can't handle this patch as-is. >> >> Maybe we can use `rm -f` and maybe that way the error isn't fatal even when >> deleting the file doesn't work, not sure. > > I can try submitting a change to make it use rm -f. Is this failure on a bot? > I didn't get any bot failure notifications. Made this change in 2f1b99ca67da18d858a4b070716790a8f53891d6 <https://reviews.llvm.org/rG2f1b99ca67da18d858a4b070716790a8f53891d6>. I see lots of "rm -f" in the tests, including elsewhere in clang_f_opts.c, so hopefully this should work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110276/new/ https://reviews.llvm.org/D110276 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
