yaxunl added inline comments.
================ Comment at: clang/test/CodeGenHIP/unsafe-atomic-ops-gfx90a.hip:13 + else + return __builtin_amdgcn_global_atomic_fadd_f32(addr, value); +} ---------------- I think we want to check the pointer argument passed to the atomic intrinsics to make sure they have addr space cast if needed. That's what your patch changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110772/new/ https://reviews.llvm.org/D110772 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
