thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land.
Very cool. ================ Comment at: clang/lib/Parse/ParsePragma.cpp:276 + + tok::OnOffSwitch OOS; + Token Tok; ---------------- Move down 10 lines until you need it? ================ Comment at: clang/lib/Parse/ParsePragma.cpp:280 + if (Tok.isNot(tok::l_paren)) { + PP.Diag(Tok.getLocation(), diag::warn_pragma_ms_fenv_access); + return; ---------------- Is it important that this is a warning? Independently if we have access to `Parser` here (not sure), there's `Parser::ExpectAndConsume`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111440/new/ https://reviews.llvm.org/D111440 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits