aaron.ballman added a comment. In D111041#3059054 <https://reviews.llvm.org/D111041#3059054>, @carlosgalvezp wrote:
> Thanks a lot for the review and the help! > > By the way, should we keep the [clang-tidy] header for the next commits? > Glancing at the commit history, I think it's much easier to see what the > commit is updating, and probably can setup email filters to only receive > notifications e.g. when [clang-tidy] is in the commit message. It's also > consistent with the rest of commits. For example this one: > > https://github.com/llvm/llvm-project/commit/a76cfc2e840ff373b80e3a5f84fc48c5f1f90d8a Eh, I personally don't care all that much one way or the other (so sure, I can do that!), but I recall there being a push to keep the "title" line under something very small (50 chars?) because of the way tools sometimes display this information to users, so I've always stripped the bit within [] to ensure we keep a sufficiently short title. That said, I'm wondering if you're planning to stick around in the clang-tidy community? If so, given that you've got a few good patches accepted already, it might be time to consider getting you commit privileges of your own. https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access has more details on what that entails. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111041/new/ https://reviews.llvm.org/D111041 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
