scanon accepted this revision. scanon added a comment. This revision is now accepted and ready to land.
I'm happy with this now. ================ Comment at: clang/docs/LanguageExtensions.rst:552 +operation(x, y) as pairwise tree reduction to the input. The pairs are formed +by concatenating both inputs and pairing adjacent elements. + ---------------- fhahn wrote: > craig.topper wrote: > > I'm not sure I understand what is being concatenated here. > I tried to spell it out more clearly. I'm still not sure if that spells it > out as clearly as possibly and I'd appreciate any suggestions on how to > improve the wording. It's unclear because there's no apparent "first" or "second" vector; there's just a single argument, and the result isn't a vector, it's a scalar. I think you want to say something like: "the operation is repeatedly applied to adjacent pairs of elements until the result is a scalar" and then provide a worked example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111529/new/ https://reviews.llvm.org/D111529 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
