dmikis added a comment. > I took a look and in its simplest form moving TextDiagnosticPrinter.cpp to > lib/Basic but also requires DiagnosticRender.cpp and TextDiagnostic.cpp to > also move to lib/Basic too, > > But DiagnosticRender.cpp has a dependency on lib/Edit so clang-format now > needs that as a dependency, is that better/worse than having a dependency on > lib/FrontEnd? (not sure why I don't have to provide "Edit" as a dependency > when including FrontEnd!)
I did make an attempt to move those classes to lib/Basic but ultimately dependency tree turned out to be too complex for me to tackle (IIRC, it basically ended up depending upon Lexer or something similar, that wasn't appropriate to move to lib/Basic). Since we used heavily patched version of clang-format (including this patch) that problem didn't bugged us and I kinda moved on to other things :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90121/new/ https://reviews.llvm.org/D90121 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
