mstorsjo added a comment. Wouldn't this one also be solved pretty much the same, but differently, by changing `if (llvm::sys::path::is_absolute(RemappedFile)) {` into `is_absolute_gnu`? Since we're remapping debug paths, it's plausible that the target path can be a different style (when cross compiling, where debug prefix remapping is kinda important), and then it's probably good to use a more lax definition of whether a path is absolute. (Alternatively, we maybe should try to detect the kind of path used and use the appropriate style as argument to `is_absolute`, but I don't think that necessarily helps here.)
(Overall I think it might be good to have the native separators and root available for tests though, even if this particular test might make sense both as-is and with native separators.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits