kiranchandramohan added a comment.
The patch looks OK. I just wanted to discuss the syntax also. Would any of the
following be better?
%8 = omp.atomic.read %addr : memref<i32> -> i32 hint(speculative, contended)
memory_order(seq_cst)
%8 = omp.atomic.read %addr hint(speculative, contended) memory_order(seq_cst)
: memref<i32> -> i32
%8 = omp.atomic.read %addr {hint(speculative, contended)
memory_order(seq_cst)} : memref<i32> -> i32
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111992/new/
https://reviews.llvm.org/D111992
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
