GMNGeoffrey added a subscriber: chandlerc.
GMNGeoffrey added a comment.
Thanks for upstreaming your fixes :-) It looks like this has some overlap with
https://reviews.llvm.org/D112399 and https://reviews.llvm.org/D111930. Let's
let those land and then see what's still necessary here
================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1336
+ linkopts = select({
+ "@bazel_tools//src/conditions:windows": ["/DEFAULTLIB:version.lib"],
+ "//conditions:default": [],
----------------
@chandlerc thoughts on this?
================
Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1805
+ "@bazel_tools//src/conditions:windows": [],
+ "//conditions:default": ["-Wno-uninitialized"],
+ }),
----------------
I don't understand why we need this at all, actually :-/ Let me investigate
================
Comment at:
utils/bazel/llvm-project-overlay/clang/include/clang/Config/config.h:78
/* Define if we have sys/resource.h (rlimits) */
-#define CLANG_HAVE_RLIMITS 1
+/* #undef CLANG_HAVE_RLIMITS */
----------------
FYI, https://reviews.llvm.org/D112399 is also fixing this
================
Comment at: utils/bazel/llvm-project-overlay/llvm/config.bzl:63
# MSVC specific
- "stricmp=_stricmp",
- "strdup=_strdup",
+ #"stricmp=_stricmp",
+ #"strdup=_strdup",
----------------
Just commenting these out isn't right. I believe you're likely hitting the same
issue fixed in https://reviews.llvm.org/D112399 with macro redefines
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112353/new/
https://reviews.llvm.org/D112353
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
