carlosgalvezp added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/cert/CERTTidyModule.cpp:328 Opts["cert-str34-c.DiagnoseSignedUnsignedCharComparisons"] = "false"; + Opts["cert-err33-c.CheckedFunctions"] = CertErr33CCheckedFunctions; return Options; ---------------- balazske wrote: > carlosgalvezp wrote: > > Same here > This is correct: 'str34' before 'err33'. No, `e` goes before `s`. The existing checks are ordered: `dcl`, `oop`, `str`. So this check should go after `dcl16`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112409/new/ https://reviews.llvm.org/D112409 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits