Hey Kirill, If you mean removing traversal of the enumdecl->enumtype in RecursiveASTVisitor, that's a subtle change that potentially affects a lot of callers. We'd need to be able to revert it, so we shouldn't rely on it to get the tests back to green.
It looks like there's a single assertion failure, can you just change the assertion to assert the (bad) current behavior? (Or revert the patches) On Tue, Oct 26, 2021 at 5:04 PM Kirill Bobyrev <kboby...@google.com> wrote: > > Yes, I'm aware and actively working on this one. I think I have the fix but > I'm trying to run all the tests (Clang etc) to make sure it doesn't break > anything else. > > On Tue, Oct 26, 2021 at 5:01 PM Nico Weber via Phabricator > <revi...@reviews.llvm.org> wrote: >> >> thakis added a comment. >> >> Follow-up commit >> https://github.com/llvm/llvm-project/commit/1c2e249f938c50e1b331a1f7adc83c0a381f3897 >> (which doesn't seem to have its own phab link) broke clangd tests >> everywhere, e.g. http://45.33.8.238/linux/59134/step_9.txt >> >> Please take a look. >> >> This is like the third clangd-caused build failure in the last 12 h or so h >> :/ >> >> >> Repository: >> rG LLVM Github Monorepo >> >> CHANGES SINCE LAST ACTION >> https://reviews.llvm.org/D112209/new/ >> >> https://reviews.llvm.org/D112209 >> _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
