rnk added a subscriber: dblaikie.
rnk added a comment.

So, to back up a bit, do I understand correctly that this change adds tests to 
the check-clang test suite that JIT compiles C++ code for the host and throws 
C++ exceptions? Can we reconsider that?

We have a policy of not running execution tests in the clang test suite because 
we know they always turn out to be unreliable, flaky, and highly dependent on 
the environment rather than the code under test. Integration tests are great, 
everyone needs them, but they should definitely not be part of the default set 
of tests that developers run anywhere and everywhere and expect to work out of 
the box, regardless of the environment. +@dblaikie to confirm if I am off base 
here about our testing strategy, and maybe Lang can advise us about past JIT 
testing strategies.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107049/new/

https://reviews.llvm.org/D107049

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to