kstoimenov added inline comments.
================ Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:92 -struct AddressSanitizerOptions { - AddressSanitizerOptions() ---------------- vitalybuka wrote: > Why do we need to remove AddressSanitizerOptions? Adding it back in as discussed offline. ================ Comment at: llvm/lib/Passes/PassRegistry.def:139 "kernel;recover") MODULE_PASS_WITH_PARAMS("asan-module", "ModuleAddressSanitizerPass", ---------------- vitalybuka wrote: > And I guess now we need to use parseASanPassOptions here? I must have reverted by an accident. Should be done now. ================ Comment at: llvm/lib/Passes/PassRegistry.def:146 }, parseModuleAddressSanitizerPassOptions, "kernel") ---------------- I think parseModuleAddressSanitizerPassOptions does exactly the same thing as parseASanPassOptions, which is to look for the "kernel" param. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112732/new/ https://reviews.llvm.org/D112732 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits