chandlerc added a comment. In D112883#3101685 <https://reviews.llvm.org/D112883#3101685>, @GMNGeoffrey wrote:
>> Is this breaking actual users? I wouldn't expect it to break unless they >> depend on this target. > > I don't know :-) I just know that people have sent me patches to remove the > repository name dependence. I think > https://github.com/llvm/llvm-project/blob/d1fdd745d510f40d8741d44ce39f5ae24ee7f91a/utils/bazel/llvm-project-overlay/clang/BUILD.bazel#L1460 > is the only previous instance in clang. That gets used only in "frontend". > I'm not sure if there are people using "ast" but not "frontend" I think users of `ast` that don't use `frontend` would be *extremely* rare. I'd like to see if this works for folks for now? The other approach we could explore is removing the reliance on file-relative inclusion of generated code completely which I think is the real sustainable answer here. CMake only causes this to work for pretty questionable reasons as-is. But it's a lot of work, and so I'd like to understand if we have to before we do. Does that seem reasonable to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112883/new/ https://reviews.llvm.org/D112883 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
