owenpan added a comment. In D95168#3100969 <https://reviews.llvm.org/D95168#3100969>, @MyDeveloperDay wrote:
> In D95168#3099920 <https://reviews.llvm.org/D95168#3099920>, @owenpan wrote: > >> In D95168#3099739 <https://reviews.llvm.org/D95168#3099739>, @MyDeveloperDay >> wrote: >> >>> - Look further into possible Removal (I have an idea for how this might be >>> possible, and super useful for LLVM where we don't like single if {} ), I'd >>> like to round out on this before introducing the options rather than having >>> to change them later >>> >>> - Should we add the possibility of removal should we change the option name >>> to "AutomaticBraces" (thoughts?) >> >> As mentioned in D95168#3039033 <https://reviews.llvm.org/D95168#3039033>, I >> think it would be better to handle the removal separately. The LLVM Coding >> Standards has an entire section >> <https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements> >> about this. Some of the listed exceptions/examples there can make things >> more difficult. > > I'm thinking more about not adding a "InsertBraces" only later to find it > should have been `InsertRemoveBraces` or `AutomaticBraces` i.e. I want to > have some idea as to how this might work, if it might be possible even if we > land separately. I think the InsertBraces options can be handled by an `enum`, but the RemoveBraces options most likely will use a `struct`. Does it make sense to have both turned on in the same configuration? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95168/new/ https://reviews.llvm.org/D95168 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
