ldionne added a comment. This broke libc++'s CI: https://buildkite.com/llvm-project/libcxx-ci/builds/6374#7569da95-c852-44f9-8b69-947245cf0b65
When you make a change to Clang AND the libc++ tests at the same time, you have to account for the fact that we support older versions of Clang. For example, here, you changed the pretty printer test, but we still run that test with Clang 12 and Clang 13, not only with Clang `main`. Since older Clangs don't contain your change, the test fails (and rightfully so). I'll add the necessary `XFAIL`s, but please look out for these breakages since they are somewhat disruptive. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111477/new/ https://reviews.llvm.org/D111477 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
