Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

[Felix Berger via cfe-commits]

flx added inline comments.

================
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:34
@@ -29,1 +33,3 @@
 
+template <typename S> bool isSetDifferenceEmpty(const S &S1, const S &S2) {
+  for (const auto &E : S1)
----------------
sbenza wrote:
> isSubset?
In the caller code it seems to me more intuitive to say we're checking whether 
the set difference is empty. But no particularly strong feelings if you think 
isSubset is more clear.


http://reviews.llvm.org/D20277



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits