vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1328
+      ClUseStackSafety ? &MAM.getResult<StackSafetyGlobalAnalysis>(M) : 
nullptr;
+  AddressSanitizer FunctionSanitizer(M, &GlobalsMD, SSGI, 
Options.CompileKernel,
+                                     Options.Recover, Options.UseAfterScope,
----------------
There is ::ProcessedAllocas which will be unnececary overpopulated with 
irrelevand allocas
Maybe add FunctionSanitizer.Reset()

But please do that  in a separate patch, this optimization is unrelated to SSGI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112098/new/

https://reviews.llvm.org/D112098

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to