rjmccall added a comment. Seems like a good idea to me. Minor request; otherwise, feel free to commit.
================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:1438 + // Add it here so that it runs prior to the BC/LL emission pass + MPM.addPass(VerifierPass()); + ---------------- This comment should be more like what you've got in your patch summary, e.g. "Add a verifier pass if requested. We don't have to do this if the action requires code generation because there will already be a verifier pass in the code-generation pipeline." (And it should go above the `if`.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113352/new/ https://reviews.llvm.org/D113352 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
