erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

In D113431#3119716 <https://reviews.llvm.org/D113431#3119716>, @ibookstein 
wrote:

> If you meant fusing the clang-format commit with this one, doing it in the 
> same commit results in git no longer detecting the connection between them 
> (similarity too low), so it loses the history. When searching I found a 
> recommendation <https://stackoverflow.com/a/51186231> to avoid combining 
> renames with modifications where git history matters, so I thought I might as 
> well :)

I'd thought about it on the other review where it was questioned to be moved, 
but i don't care that much...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113431/new/

https://reviews.llvm.org/D113431

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to