JonChesterfield added reviewers: tianshilei1992, ye-luo, jhuber6. JonChesterfield added a comment.
That seems important. What was the symptom of failing to set these? We may now be redundantly setting some, e.g. I think convergent is set somewhere else before this patch. Added a few people who may be able to run the patch against nvptx to check for regressions. If there isn't already a nvptx attribute test we should commit one before this patch so we can see the change. If there is already one, then we haven't changed it here and all is good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113538/new/ https://reviews.llvm.org/D113538 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
