sammccall added inline comments.
================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:517
+ Completion.Kind == CompletionItemKind::Method ||
+ Completion.Kind == CompletionItemKind::Text /*Macro*/) {
// Functions snippets can be of 2 types:
----------------
kadircet wrote:
> again while here, maybe introduce constructors into this condition. (Even
> better, what about a `bool isFunctionLikeCompletion(const CompletionItem&)`
> that we can use both here and above?)
Done, though I didn't want to extract the variable too far away as there are
some wrinkles (macros may not be function-like, template args...) that we can
get away without resolving here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113765/new/
https://reviews.llvm.org/D113765
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
