vsapsai added a comment.
Haven't checked the details of serialization/deserialization. High-level
question about different serialization approaches (bitvector vs list of file
ids) is in D112915 <https://reviews.llvm.org/D112915>.
================
Comment at: clang/lib/Lex/Preprocessor.cpp:552
+ if (const FileEntry *FE = SourceMgr.getFileEntryForID(MainFileID)) {
+ HeaderInfo.getFileInfo(FE);
+ markIncluded(FE);
----------------
Why do you need to `getFileInfo` but don't use it? I have no objections but it
looks like it deserves a comment because it's not obvious.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114095/new/
https://reviews.llvm.org/D114095
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
