mojca added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131
+ std::initializer_list<const char *> Versions = {
+ "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1",
+ "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"};
----------------
kadircet wrote:
> looks like the list is getting big and hard to maintain. considering that
> this is done only once per compiler invocation (and we check for existence of
> directories down in the loop anyway). what about throwing in an extra
> directory listing to base-directories mentioned down below and populate
> `Candidates` while preserving the newest-version-first order?
I totally agree with the sentiment, and that was my initial thought as well,
but with zero experience I was too scared to make any more significant changes.
I can try to come up with a new patch (that doesn't need further maintenance
whenever a new CUDA version gets released) if that's what you are suggesting. I
would nevertheless merge this one, and prepare a new more advanced patch
separately, but that's finally your call.
What's your suggestion about D.SysRoot + "Program Files/..."? At the time when
this function gets called it looks like D.SysRoot is empty (or at least my
debugger says so) and in my case it resolves to D: while the CUDA support is
installed under C:.
Is there any special LLVM-specific/preferrable way to iterate through
directories?
(What I also miss a bit in the whole process in an option to simply say "I want
CUDA 11.1" without the need to explicitly spell out the full path.)
If you provide me give some general guidelines, I'll prepare another, hopefully
more future-proof patch.
(Side note: I'm not sure if I'm calling clang-format correctly, but if I call
it, it keeps reformatting the rest of this file.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114326/new/
https://reviews.llvm.org/D114326
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
