lebedev.ri added a comment. In D114317#3150615 <https://reviews.llvm.org/D114317#3150615>, @carlosgalvezp wrote:
>> it is likely that the options were tuned, but most likely only for a single >> check. > > Yes, if the alias check has a different configuration than the primary check > then they are considered as "different" checks (as they should be, since they > produce potentially different outputs and some people might lose coverage). Yep. > Perhaps it would be interesting to add something to the "--explain-config" > flag so the user understands why some checks are/aren't enabled. >> I still maintain that there should be a single opt-in option to completely >> disable all aliasee checks. > > By "aliasee" do you mean "alias" checks (as opposed to "primary" check)? I'm > a bit confused by the terminology :) Yes. > In order words, are you proposing to opt-in to disable all alias checks, > leaving only the primary check (regardless of configuration)? I suppose this > should be fairly easy to implement, just don't check the configuration when > removing aliases. We can support both options for people having different use > cases. IMO that would be best, otherwise this still seems like a half a solution :/ (not that this is worse than currently) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114317/new/ https://reviews.llvm.org/D114317 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
